[5.x] Prevent infinite loops with Laravel Telescope #11390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with Laravel Telescope installed, where an infinite loop would occur if you had entries which link to each other.
Right now, when Telescope encounters an
Entry
object (whether that be in an event, or in an authorization gate), it'll attempt to serialize it using->jsonSerialize()
which'll return an evaluated array of the augmented entry.However, if you have an entry which relates back to itself, this evaluated array can cause an infinite loop.
This PR addresses that by returning a shallow augmented array instead, which prevents relationships from being evaluated in the same way, therefore preventing the infinite loop issue.
This fix relies on the
formatForTelescope
method, added in laravel/telescope#1562. You'll need to be using Telescope v5.4.0 or above for this fix to work.Fixes #10782.