[5.x] Export starter kit package
folder when it exists
#11119
+201
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
When making a kit composer updatable (by setting
updatable: true
introduced by #11064), you're likely going to want to provide your own package service provider class, PSR-4 namespace, vendor views, etc. that are separate fromexport_paths
(which get installed into the users app, rather than remaining invendor
). Right now there is no way to automatically export those vendor files to your starter kit repo.The Solution
In this PR, we allow you to create your own
package
folder in your dev application for all your package'svendor
files. When runningphp please starter-kit:export
, if we detect that apackage
folder exists, we'll export all of those files to your starter kit package's root path, and scope allexport_paths
to an export folder to keep things clean and free from filename conflict with installableexport_paths
.For example, if this is your dev app...
Then this is what the final export will look like...
This lets you manage your package's
composer.json
, etc. from thepackage
folder, and the exporter and installer will intelligently put Everything in Its Right Place, just like Radiohead.Todo