Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phash duration cutoff option #761

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

InfiniteStash
Copy link
Collaborator

Phashes for short clips can cause issues because they generally don't contain enough details to uniquely identify a clip, which causes them to clump together along with associated md5/oshash fingerprints. An example is https://stashdb.org/scenes/e46fa5b8-7c3a-4db6-8522-17abeb26bfbb#fingerprints

I'm not sure what the best cutoff is, but at least 1-2mins I think, depending on content.

@DogmaDragon
Copy link
Contributor

DogmaDragon commented Feb 25, 2024

Not sure what caused the mess in the example, but on FansDB side we have been dealing with very short durations (as short 1-2 seconds) and we haven't experienced anything like this (scale is close to 30k scenes).

An alternative to this would be modifying the hash algorithm to better deal with lack of unique details, like proposed in stashapp/stash#4074.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants