Skip to content

Update markerTagToScene for new Javascript runtime #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2024

Conversation

Maista6969
Copy link
Collaborator

Not sure when this happened but the input to Javascript plugins appears to be PascalCase instead of snake_case now so this plugin wasn't working

I also changed it so that it adds not just the primary tag from the marker but also any additional tags, if present

@Maista6969 Maista6969 merged commit 5ac0022 into main May 26, 2024
2 checks passed
@Maista6969 Maista6969 deleted the update-markerTagToScene branch May 26, 2024 08:52
@DogmaDragon DogmaDragon linked an issue May 26, 2024 that may be closed by this pull request
@p0rnb0x
Copy link
Contributor

p0rnb0x commented May 29, 2024

hello,
plugin broken now for me. is new JavaScript runtime coming in 0.26.0?
on 0.25.1 this commit breaks plugin for me. getting a lot of errors like this:

/config/plugins/community/markerTagToScene/markerTagToScene.js: Line 26:18 Unexpected token . (and 32 more errors)

@Maista6969
Copy link
Collaborator Author

I apologize for the inconvenience: the new runtime is available in latest_develop and will be in v0.26.0
stashapp/stash@v0.25.1...latest_develop

In the mean time you can revert your plugin file to the previous version

@p0rnb0x
Copy link
Contributor

p0rnb0x commented May 30, 2024

thank you friend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[markerTagToScene] Add all tags of Scene Marker to the Scene
2 participants