-
-
Notifications
You must be signed in to change notification settings - Fork 171
[markerTagToScene] add all marker tags to scene not just primary #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
looks at all marker tags from `SceneMarkerUpdateInput` and compares them to existing scene `tag_ids` adds any tags that are missing from scene
so js plugins seem to have an issue with arrow functions as well as some other issues I'm unfamiliar with, I could rewrite this in python but I'm not sure that is the ideal solution here so I will draft a PF for it if it is not wanted feel free to close it |
bumps version to 2.0 as language change here is somewhat significant
following. it works with this merge request with no issues |
@stg-annon sorry for the late review |
@stg-annon still feel the same way? This has sat a while and between this and #154 , and #152. i think one of these go in, or some hybrid approach. Preference? |
this would be easy for me to maintain but I don't love introducing requirements where I don't have to, if |
looks at all marker tags from
SceneMarkerUpdateInput
and compares them to existing scenetag_ids
adds any tags that are missing from scene