Allways transform rel_name to underscore #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kennstenicht I'd like to merge it, but I think we should make the whole deserialization support pluggable. Let me know if you have time to continue the work on it. 🙇 |
stas
reviewed
Feb 22, 2021
| @@ -62,7 +62,7 @@ def jsonapi_deserialize(document, options = {}) | |||
|
|
|||
| relationships.map do |assoc_name, assoc_data| | |||
| assoc_data = (assoc_data || {})['data'] || {} | |||
| rel_name = jsonapi_inflector.singularize(assoc_name) | |||
| rel_name = jsonapi_inflector.singularize(assoc_name).underscore | |||
There was a problem hiding this comment.
@kennstenicht we will want to call the jsonapi_inflector.underscore separately, otherwise non-rails usage will not be supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
If i set
set_key_transform :dashin my serializer all keys, including the relationship names are dasherized. But relationships with dasherized names are exluded if "only" or "except" option is set, because params inside the only or except options needs to be underscore.What is the new behavior?
Now I am able to define the parms inside my option in dasherized or any other format.
jsonapi_deserialize(params, only: [dasherized-relation-name])Checklist
Please make sure the following requirements are complete:
features)