Fix for communicator bug in MPI cache #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blixodus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rank translation from the MPI communicator of the task to
MPI_COMM_WORLDwhen checking if data needs to be exchanged before execution. This mitigates the issue raised in https://sympa.inria.fr/sympa/arc/starpu-devel/2024-12/msg00001.html and avoids StarPU mistakenly believing that some data has already been sent to a node that has the same rank as another node in some communicator.The fix is somewhat slow (~1-2µs per translation); a better way would be to precompute all rank translations into a lookup table when registering new MPI communicators to StarPU.