Skip to content

Commit

Permalink
Add TODO about updating the priority of cached MPI communications
Browse files Browse the repository at this point in the history
  • Loading branch information
philippemilink committed Aug 6, 2024
1 parent 0684bac commit a83eeba
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion mpi/src/starpu_mpi_task_insert.c
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,18 @@ int _starpu_mpi_exchange_data_before_execution(starpu_data_handle_t data, enum s
_STARPU_MPI_DEBUG(1, "Sending data %p to %d with prio %d\n", data, xrank, prio);
_SEND_DATA(data, mode, xrank, data_tag, prio, comm, NULL, NULL);
}
// Else the data has already been sent
/* Else the data has already been sent
*
* TODO: if the cached communication did not start yet, and if
* the priority of the ignored communication is higher than the
* cached communication, change the priority of the cached
* communication to reflect it is actually needed with a higher
* priority.
* In StarPU-MPI this can be done while the request is in the
* ready_send_requests list and before its MPI_Isend is issued;
* with StarPU-NewMadeleine, it requires explicit support from
* NewMadeleine (management of list of send requests is done
* directly by NewMadeleine). */
}
}
return 0;
Expand Down

0 comments on commit a83eeba

Please sign in to comment.