Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive lookup data impl #946

Open
wants to merge 1 commit into
base: ohad/uninutialized_trace
Choose a base branch
from

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced Dec 23, 2024
Copy link
Collaborator Author

ohad-starkware commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 95.02408% with 31 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (5b504ae) to head (cc83477).

Files with missing lines Patch % Lines
crates/air_utils_derive/src/iterable_field.rs 90.47% 22 Missing ⚠️
crates/air_utils_derive/src/lib.rs 77.77% 6 Missing ⚠️
crates/air_utils/src/lookup_data/mod.rs 96.84% 3 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           ohad/uninutialized_trace     #946      +/-   ##
============================================================
+ Coverage                     92.09%   92.22%   +0.12%     
============================================================
  Files                            99      105       +6     
  Lines                         13475    14098     +623     
  Branches                      13475    14098     +623     
============================================================
+ Hits                          12410    13002     +592     
- Misses                          995     1026      +31     
  Partials                         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 3f68c17 to 41aafa0 Compare December 23, 2024 15:37
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch 2 times, most recently from c1f8418 to 337276c Compare December 23, 2024 16:35
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 337276c to 1ef4c48 Compare December 24, 2024 07:32
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 1ef4c48 to 3de81b1 Compare December 24, 2024 08:35
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 3de81b1 to 0fb1f67 Compare December 24, 2024 08:45
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 0fb1f67 to 2b0e92f Compare December 24, 2024 10:00
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 2b0e92f to 09d916f Compare December 24, 2024 10:44
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 09d916f to 69f144c Compare December 24, 2024 11:00
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 69f144c to 1d30324 Compare December 25, 2024 13:57
@ohad-starkware ohad-starkware changed the base branch from ohad/par_lookup_data to ohad/uninutialized_trace December 25, 2024 13:57
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch 3 times, most recently from 061d9f9 to 4a711fd Compare December 25, 2024 14:36
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch 3 times, most recently from 8d79f7d to 7f37be3 Compare December 25, 2024 15:24
@ohad-starkware ohad-starkware force-pushed the ohad/uninutialized_trace branch from 659ec4d to e333aec Compare December 25, 2024 15:57
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 7f37be3 to 0ff6d04 Compare December 25, 2024 15:58
@ohad-starkware ohad-starkware force-pushed the ohad/uninutialized_trace branch from e333aec to 1e8728c Compare December 26, 2024 09:11
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch 2 times, most recently from 9efe648 to 89bc987 Compare December 26, 2024 09:26
@ohad-starkware ohad-starkware force-pushed the ohad/uninutialized_trace branch from 1e8728c to 5a3e44f Compare December 26, 2024 09:35
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch 2 times, most recently from 222c42f to d291eb2 Compare December 26, 2024 09:39
@ohad-starkware ohad-starkware force-pushed the ohad/uninutialized_trace branch from 5a3e44f to 7e6a7b6 Compare December 26, 2024 13:04
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch 2 times, most recently from b74b784 to 2578f96 Compare December 26, 2024 13:07
@ohad-starkware ohad-starkware force-pushed the ohad/uninutialized_trace branch from 7e6a7b6 to 06dff4d Compare December 26, 2024 14:13
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 2578f96 to aeeef53 Compare December 26, 2024 14:13
@ohad-starkware ohad-starkware force-pushed the ohad/uninutialized_trace branch from 06dff4d to 34c2608 Compare December 26, 2024 14:16
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from aeeef53 to 05a469f Compare December 26, 2024 14:17
@ohad-starkware ohad-starkware force-pushed the ohad/uninutialized_trace branch from 34c2608 to 5b504ae Compare December 26, 2024 14:17
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 05a469f to 8d1ef9b Compare December 26, 2024 14:17
@ohad-starkware ohad-starkware force-pushed the ohad/lookup_data_derive_2 branch from 8d1ef9b to cc83477 Compare December 26, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants