Add n_preprocessed_columns to Components. #874
Merged
+54
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ilyalesokhin-starkware
force-pushed
the
ilya/components
branch
from
916e531
to
886ef0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #874 +/- ##
==========================================
+ Coverage 91.90% 91.92% +0.01%
==========================================
Files 92 92
Lines 12608 12626 +18
Branches 12608 12626 +18
==========================================
+ Hits 11588 11606 +18
Misses 910 910
Partials 110 110 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 886ef0c | Previous: f6214d1 | Ratio |
|---|---|---|---|
iffts/simd ifft/27 |
632562712 ns/iter (± 27518404) |
312325137 ns/iter (± 5094310) |
2.03 |
merkle throughput/simd merkle |
29922330 ns/iter (± 633019) |
14690867 ns/iter (± 434150) |
2.04 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
ilyalesokhin-starkware
force-pushed
the
ilya/components
branch
from
886ef0c
to
4dd55f9
Compare
ohad-starkware
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
ilyalesokhin-starkware
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.