Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reference blake2s doc #858

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

dlubarov
Copy link
Contributor

@dlubarov dlubarov commented Oct 5, 2024

This change is Reviewable

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reference to this implementation and wanted to credit the writer.
Why do you suggest to change this doc?

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@dlubarov
Copy link
Contributor Author

dlubarov commented Nov 3, 2024

Oh, I'll add back the link then, but An AVX512 implementation seems like accidental copypasta in 9dbe5bc (or so I thought) since this one is the pure Rust implementation.

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's probably right

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @dlubarov)


crates/prover/src/core/vcs/blake2s_ref.rs line 2 at r2 (raw file):

//! A reference implementation of the BLAKE2s compression function, in pure Rust.
//! Based on https://github.com/oconnor663/blake2_simd/blob/master/blake2s/src/avx2.rs .

one small comment

Suggestion:

//! Based on <https://github.com/oconnor663/blake2_simd/blob/master/blake2s/src/avx2.rs>.

@dlubarov
Copy link
Contributor Author

dlubarov commented Nov 7, 2024

Done

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlubarov)

@shaharsamocha7 shaharsamocha7 merged commit 22ddcfe into starkware-libs:dev Nov 12, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants