-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the reference blake2s doc #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reference to this implementation and wanted to credit the writer.
Why do you suggest to change this doc?
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Oh, I'll add back the link then, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's probably right
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @dlubarov)
crates/prover/src/core/vcs/blake2s_ref.rs
line 2 at r2 (raw file):
//! A reference implementation of the BLAKE2s compression function, in pure Rust. //! Based on https://github.com/oconnor663/blake2_simd/blob/master/blake2s/src/avx2.rs .
one small comment
Suggestion:
//! Based on <https://github.com/oconnor663/blake2_simd/blob/master/blake2s/src/avx2.rs>.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlubarov)
This change is