Change Eval Framework Copy requirement to Clone.

[Alon-Ti]

This change is 

[Alon-Ti]

• Formal polynomial evaluator. #836
• Formal polynomials. #835
• Change Eval Framework Copy requirement to Clone. #834 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Alon-Ti and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 97.89474% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.58%. Comparing base (f787197) to head (5cea2f8).

Files with missing lines	Patch %	Lines
...es/prover/src/core/backend/simd/very_packed_m31.rs	0.00%	0 Missing and 1 partial ⚠️
crates/prover/src/core/lookups/utils.rs	94.44%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #834   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          89       89           
  Lines       12017    12018    +1     
  Branches    12017    12018    +1     
=======================================
+ Hits        11126    11127    +1     
+ Misses        784      781    -3     
- Partials      107      110    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrewmilson]

Reviewable status: 0 of 23 files reviewed, 2 unresolved discussions (waiting on @Alon-Ti and @shaharsamocha7)

---

crates/prover/src/constraint_framework/mod.rs line 87 at r1 (raw file):

    ) -> [Self::EF; N] {
        let res_col_major = array::from_fn(|_| self.next_interaction_mask(interaction, offsets));
        array::from_fn(|i| Self::combine_ef(res_col_major.clone().map(|c| c[i].clone())))

Suggestion: without clone

Suggestion:

        let mut res_col_major =
            array::from_fn(|_| self.next_interaction_mask(interaction, offsets).into_iter());
        array::from_fn(|_| {
            Self::combine_ef(res_col_major.each_mut().map(|iter| iter.next().unwrap()))
        })

---

crates/prover/src/core/fields/mod.rs line 100 at r1 (raw file):

    + Neg<Output = Self>
    + ComplexConjugate
    + Copy

Does this need to have Copy removed?

Code quote:

+ Copy

[shaharsamocha7]

Reviewable status: 0 of 23 files reviewed, 3 unresolved discussions (waiting on @Alon-Ti and @andrewmilson)

a discussion (no related file):
Main change here is that we removed the Copy trait for Field?
Can you explain why is it better?

---