Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arithmetic op counts to InfoEvaluator #832

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Sep 16, 2024

Couldn't see a way to add the counting types without removing Copy from a few places.
Some constraint code is a bit more ugly now :(


This change is Reviewable

Copy link
Contributor Author

andrewmilson commented Sep 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andrewmilson and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 92.20779% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (ba4205c) to head (d79f369).

Files with missing lines Patch % Lines
crates/prover/src/constraint_framework/info.rs 89.88% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           09-11-Add_size_estimate_for_StarkProof     #832      +/-   ##
==========================================================================
- Coverage                                   91.92%   91.85%   -0.07%     
==========================================================================
  Files                                          89       89              
  Lines                                       12154    12296     +142     
  Branches                                    12154    12296     +142     
==========================================================================
+ Hits                                        11173    11295     +122     
- Misses                                        874      890      +16     
- Partials                                      107      111       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from 2071d27 to 4c79a3d Compare September 16, 2024 05:15
@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from 4c79a3d to d79f369 Compare September 16, 2024 05:23
Base automatically changed from 09-11-Add_size_estimate_for_StarkProof to dev September 16, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants