Revert logup without is_first

[shaharsamocha7]

This change is 

[shaharsamocha7]

• trace in bit reverse order #857
• State machine prover #845
• State machine AIR #841
• Add constraint for Logup claimed cumsum #830
• Logup generator returns multiple prefix sums #829
• Logup - rename claimed_sum to total_sum #825
• Revert logup without is_first #818 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shaharsamocha7 and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (1ee6a70) to head (a3a9330).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #818      +/-   ##
==========================================
- Coverage   92.76%   92.73%   -0.03%     
==========================================
  Files          89       89              
  Lines       12041    12033       -8     
  Branches    12041    12033       -8     
==========================================
- Hits        11170    11159      -11     
- Misses        764      767       +3     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrewmilson]

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)

---

crates/prover/src/constraint_framework/logup.rs line 71 at r3 (raw file):

        // Fix `prev_row_cumsum` by subtracting `claimed_sum` if this is the first row.
        let fixed_prev_row_cumsum = prev_row_cumsum - self.is_first * self.claimed_sum;
        let diff = cur_cumsum - fixed_prev_row_cumsum - self.prev_col_cumsum;

Isn't it more efficient how it was before?

Code quote:

        // Fix `prev_row_cumsum` by subtracting `claimed_sum` if this is the first row.
        let fixed_prev_row_cumsum = prev_row_cumsum - self.is_first * self.claimed_sum;
        let diff = cur_cumsum - fixed_prev_row_cumsum - self.prev_col_cumsum;

[shaharsamocha7]

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @andrewmilson)

---

crates/prover/src/constraint_framework/logup.rs line 71 at r3 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

Isn't it more efficient how it was before?

It was (by a bit), but I wanted to add the is_first column for the padding feature and wanted those to use the same mechanism

[Alon-Ti]

Reviewed 4 of 7 files at r1, 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

[andrewmilson]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)