Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MleCollection for accumulating MLEs #800

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Aug 22, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.25%. Comparing base (793a498) to head (1c00ec1).

Files Patch % Lines
crates/prover/src/core/fields/qm31.rs 33.33% 6 Missing ⚠️
crates/prover/src/core/backend/simd/column.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #800      +/-   ##
==========================================
- Coverage   92.33%   92.25%   -0.08%     
==========================================
  Files          91       91              
  Lines       12467    12484      +17     
  Branches    12467    12484      +17     
==========================================
+ Hits        11511    11517       +6     
- Misses        850      861      +11     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 08-21-Combine_eq_step_constraints_into_single_constraint branch 4 times, most recently from 486c573 to 42f2f6f Compare August 23, 2024 21:49
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from 338e26f to 5596e74 Compare August 23, 2024 23:39
@andrewmilson andrewmilson marked this pull request as ready for review August 24, 2024 02:33
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from 5596e74 to 573ee79 Compare August 24, 2024 03:30
@andrewmilson andrewmilson force-pushed the 08-21-Combine_eq_step_constraints_into_single_constraint branch from 42f2f6f to 8c909c4 Compare August 26, 2024 04:15
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from 573ee79 to 22ae396 Compare August 26, 2024 04:15
@andrewmilson andrewmilson force-pushed the 08-21-Combine_eq_step_constraints_into_single_constraint branch from 8c909c4 to efe945e Compare August 26, 2024 04:18
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from 22ae396 to d2f052c Compare August 26, 2024 04:18
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@andrewmilson andrewmilson force-pushed the 08-21-Combine_eq_step_constraints_into_single_constraint branch from efe945e to 97e84fa Compare August 26, 2024 15:24
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from d2f052c to 1ac18ac Compare August 26, 2024 16:18
@andrewmilson andrewmilson force-pushed the 08-21-Combine_eq_step_constraints_into_single_constraint branch from 97e84fa to 2d6cc30 Compare August 28, 2024 02:02
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from 1ac18ac to 8cc4e98 Compare August 28, 2024 02:02
@andrewmilson andrewmilson force-pushed the 08-21-Combine_eq_step_constraints_into_single_constraint branch from 2d6cc30 to 8b81736 Compare August 28, 2024 02:11
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from 8cc4e98 to f0349c6 Compare August 28, 2024 02:11
@andrewmilson andrewmilson force-pushed the 08-21-Combine_eq_step_constraints_into_single_constraint branch from 8b81736 to a4dc0be Compare August 28, 2024 02:18
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from f0349c6 to 0f648e0 Compare August 28, 2024 02:18
@andrewmilson andrewmilson force-pushed the 08-21-Combine_eq_step_constraints_into_single_constraint branch from a4dc0be to c3af357 Compare August 28, 2024 03:07
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from 0f648e0 to dc03192 Compare August 28, 2024 03:07
Base automatically changed from 08-21-Combine_eq_step_constraints_into_single_constraint to dev August 28, 2024 12:57
@andrewmilson andrewmilson force-pushed the 08-20-Add_MleCollection_for_accumulating_MLEs branch from dc03192 to 1c00ec1 Compare August 28, 2024 13:00
@andrewmilson andrewmilson merged commit 1003bf2 into dev Aug 28, 2024
16 checks passed
@andrewmilson andrewmilson deleted the 08-20-Add_MleCollection_for_accumulating_MLEs branch August 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants