Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use index util funtions outside of crate. #719

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jul 10, 2024

This change is Reviewable

@alonh5 alonh5 force-pushed the 07-10-use_index_util_funtions_outside_of_crate branch from c2962c0 to 472e647 Compare July 10, 2024 13:37
Copy link
Contributor Author

alonh5 commented Jul 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite Graphite

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 force-pushed the 07-10-use_index_util_funtions_outside_of_crate branch from 472e647 to 040e43b Compare July 10, 2024 13:43
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base (496323f) to head (040e43b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #719   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files          76       76           
  Lines       10165    10165           
  Branches    10165    10165           
=======================================
  Hits         9202     9202           
  Misses        881      881           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 07-10-use_index_util_funtions_outside_of_crate branch from 040e43b to 835766b Compare July 11, 2024 11:31
@alonh5 alonh5 merged commit 2501444 into dev Jul 11, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants