Poseidon2

[spapinistarkware]

This change is 

[spapinistarkware]

• Poseidon2 #683 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (f59f722) to head (ee39b89).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #683      +/-   ##
==========================================
+ Coverage   89.94%   89.95%   +0.01%     
==========================================
  Files          75       75              
  Lines        9645     9657      +12     
  Branches     9645     9657      +12     
==========================================
+ Hits         8675     8687      +12     
  Misses        889      889              
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

---

crates/prover/src/examples/poseidon/mod.rs line 184 at r1 (raw file):

// Applies the internal round matrix.
// See https://eprint.iacr.org/2023/323.pdf 5.2 .
fn apply_internal_round_matrix<F>(state: &mut [F; 16])

Do we need to add round constants here?

Code quote:

fn apply_internal_round_matrix<F>(state: &mut [F; 16])

[shaharsamocha7]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/src/examples/poseidon/mod.rs line 183 at r1 (raw file):

// Applies the internal round matrix.
// See https://eprint.iacr.org/2023/323.pdf 5.2 .

Can you state here what are the \mu that you are using?

Code quote:

// See https://eprint.iacr.org/2023/323.pdf 5.2 .

---

crates/prover/src/examples/poseidon/mod.rs line 188 at r1 (raw file):

    F: Copy + AddAssign<F> + Add<F, Output = F> + Sub<F, Output = F> + Mul<BaseField, Output = F>,
{
    // TODO(spapini): Check that these coefficients are good according to Seciotn 5.3 of Poseidon2

Suggestion:

// TODO(spapini): Check that these coefficients are good according to Section 5.3 of Poseidon2

[shaharsamocha7]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/src/examples/poseidon/mod.rs line 334 at r1 (raw file):

}

// TODO(AlonH): Implement.

Remove

Code quote:

// TODO(AlonH): Implement.

[spapinistarkware]

Reviewable status: 5 of 7 files reviewed, 4 unresolved discussions (waiting on @shaharsamocha7)

---

crates/prover/src/examples/poseidon/mod.rs line 183 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Can you state here what are the \mu that you are using?

Done.

---

crates/prover/src/examples/poseidon/mod.rs line 188 at r1 (raw file):

    F: Copy + AddAssign<F> + Add<F, Output = F> + Sub<F, Output = F> + Mul<BaseField, Output = F>,
{
    // TODO(spapini): Check that these coefficients are good according to Seciotn 5.3 of Poseidon2

Done.

---

crates/prover/src/examples/poseidon/mod.rs line 334 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Remove

Done.

[shaharsamocha7]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

[spapinistarkware]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

crates/prover/src/examples/poseidon/mod.rs line 184 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Do we need to add round constants here?

Added at the callsite

[shaharsamocha7]

Reviewed 2 of 2 files at r3.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @spapinistarkware)

[shaharsamocha7]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)