-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 'Sum' and 'Product' on field types #497
Conversation
f4cbb07
to
c61253e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #497 +/- ##
==========================================
- Coverage 95.57% 95.26% -0.32%
==========================================
Files 58 58
Lines 8884 8913 +29
Branches 8884 8913 +29
==========================================
Hits 8491 8491
- Misses 344 373 +29
Partials 49 49 ☔ View full report in Codecov by Sentry. |
c61253e
to
5960d2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @ohad-starkware)
a discussion (no related file):
Could you give some context as to why we need these and where they're going to be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @ohad-starkware)
a discussion (no related file):
Previously, alonh5 (Alon Haramati) wrote…
Could you give some context as to why we need these and where they're going to be used?
Computing the sum and product is a common operation. I do it in my next PRs. Also there is an open PR that could already use this https://github.com/starkware-libs/stwo/pull/506/files#diff-bf237a27a0c3209b3f17119d6b863f0b16a65d0e7950f07dcca80ccbdf14a147R114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)
src/core/fields/mod.rs
line 169 at r1 (raw file):
($field_name: ty, $field_size: ident) => { use std::iter::{Product, Sum};
is the space here by intent?
This change is