Use precomputed twiddles

[spapinistarkware]

This change is 

[spapinistarkware]

• parallel wide fib test #511
• Evaluation oods once #496
• Reuse commitment evaluation #495
• Use precomputed twiddles #494 👈
• Add measurement logs #493
• WideFib test with AVX Backend #492
• Make prove() generic in Backend #490 : 1 other dependent PR (#491 )
• CommitmentSchemeProver generic in backend #489
• Fri AVX ops #563
• AVX quotients #488
• Remove old merkle #531 : 1 other dependent PR (#486 )
• FRI using simple merkle #530
• Dumb down FRI #529
• avx merkle #528
• simple merkle benchmark #527
• Use simple merkle tree #526
• merkle intermediate layers #548
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (spapini/03-16-add_measurement_logs@1b54a8c). Click here to learn what that means.

Additional details and impacted files

@@                          Coverage Diff                          @@
##             spapini/03-16-add_measurement_logs     #494   +/-   ##
=====================================================================
  Coverage                                      ?   94.26%           
=====================================================================
  Files                                         ?       66           
  Lines                                         ?     8407           
  Branches                                      ?     8407           
=====================================================================
  Hits                                          ?     7925           
  Misses                                        ?      418           
  Partials                                      ?       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5 and @spapinistarkware)

---

src/core/prover/mod.rs line 75 at r1 (raw file):

    let span = span!(Level::INFO, "Precompute twiddle").entered();
    let twiddles = B::precompute_twiddles(
        CanonicCoset::new(air.composition_log_degree_bound() + 1)

• LOG_BLOWUP_FACTOR?

Code quote:

 + 1

---

src/core/prover/mod.rs line 387 at r1 (raw file):

            },
        };
        let domain = CanonicCoset::new(LOG_DOMAIN_SIZE).circle_domain();

What's that change?

Code quote:

CanonicCoset::new(LOG_DOMAIN_SIZE).circle_domain();

[spapinistarkware]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @shaharsamocha7)

---

src/core/prover/mod.rs line 75 at r1 (raw file):

Previously, shaharsamocha7 wrote…

• LOG_BLOWUP_FACTOR?

Done.

---

src/core/prover/mod.rs line 387 at r1 (raw file):

Previously, shaharsamocha7 wrote…

What's that change?

Done.

[shaharsamocha7]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5 and @spapinistarkware)

a discussion (no related file):
Do we need to add a "Could not compute twiddles for this domain" error?

---

[shaharsamocha7]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[spapinistarkware]

Merge activity

• Apr 15, 7:31 AM EDT: @spapinistarkware started a stack merge that includes this pull request via Graphite.
• Apr 15, 7:33 AM EDT: Graphite rebased this pull request as part of a merge.
• Apr 15, 7:35 AM EDT: @spapinistarkware merged this pull request with Graphite.