Skip to content

Commit

Permalink
Add OODS verification error. (#502)
Browse files Browse the repository at this point in the history
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/stwo/502)
<!-- Reviewable:end -->
  • Loading branch information
alonh5 committed Mar 20, 2024
1 parent 609d2c1 commit a4a48c7
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions src/core/prover/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,11 @@ pub fn verify(
&proof.trace_oods_values,
random_coeff,
);
assert_eq!(
composition_polynomial_oods_value,
combine_secure_value(proof.composition_polynomial_column_oods_values)
);
if composition_polynomial_oods_value
!= combine_secure_value(proof.composition_polynomial_column_oods_values)
{
return Err(VerificationError::OodsNotMatching);
}
channel.mix_felts(&proof.trace_oods_values.flatten());
channel.mix_felts(&proof.composition_polynomial_column_oods_values);

Expand Down Expand Up @@ -303,6 +304,11 @@ pub enum ProvingError {

#[derive(Clone, Copy, Debug, Error)]
pub enum VerificationError {
#[error(
"The composition polynomial OODS value does not match the trace OODS values
(DEEP-ALI failure)."
)]
OodsNotMatching,
#[error(transparent)]
Fri(#[from] FriVerificationError),
}
Expand Down

0 comments on commit a4a48c7

Please sign in to comment.