Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run npm run validate_all
).starknet_api_openrpc.json
:./api/starknet_api_openrpc.json
and./starknet_api_openrpc.json
references; changed it to only use the formerapi/
)This is open for discussion. I can change thename
in package.json to maybe reflect the whole repository, not just the validation tooling (e.g."name": "starknet_specs"
instead of"name": "openrpc_scripts"
).Alternatively, another source of truth can be used (e.g. env var or env file)"name": "openrpc_scripts"
to"name": "starknet_specs"
so that it reflects the whole repository, not just the validation toolingNow that validation has been fixed, when running it locally, a validation error is reported in
api/starknet_trace_api_openrpc.json
:This change is