Add v3 transactions additional fields #162
Conversation
| "title": "L2 Gas", | ||
| "description": "The max amount and max price per unit of L2 gas used in this tx", | ||
| "$ref": "#/components/schemas/RESOURCE_LIMITS" | ||
| }, |
There was a problem hiding this comment.
Note the structure of l1_gas, l2_gas is different in the GW and FGW, would be nicer if they'd be the same:
"resource_bounds": {
"L1_GAS": {
"max_amount": "0x5",
"max_price_per_unit": "0x6"
},
"L2_GAS": {
"max_amount": "0x0",
"max_price_per_unit": "0x0"
}
},
| "l2_gas", | ||
| "tip", | ||
| "paymaster_data", | ||
| "account_deployment_data", |
There was a problem hiding this comment.
why is "account_deployment_data" relevant for declare?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Yael-Starkware)
api/starknet_api_openrpc.json line 1890 at r1 (raw file):
Previously, Yael-Starkware (yael-starkware) wrote…
Note the structure of l1_gas, l2_gas is different in the GW and FGW, would be nicer if they'd be the same:
"resource_bounds": {
"L1_GAS": {
"max_amount": "0x5",
"max_price_per_unit": "0x6"
},
"L2_GAS": {
"max_amount": "0x0",
"max_price_per_unit": "0x0"
}
},
Done.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Yael-Starkware)
api/starknet_api_openrpc.json line 1935 at r1 (raw file):
Previously, Yael-Starkware (yael-starkware) wrote…
why is "account_deployment_data" relevant for declare?
still not clear if we'll keep it, will be decided in the next RC
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp)
There was a problem hiding this comment.
Dismissed @Yael-Starkware from 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArielElp)
This change is