Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SKIP_FEE_CHARGE flag to simulate #109

Merged
merged 1 commit into from
Jul 6, 2023
Merged

add SKIP_FEE_CHARGE flag to simulate #109

merged 1 commit into from
Jul 6, 2023

Conversation

EvyatarO
Copy link
Collaborator

@EvyatarO EvyatarO commented Jul 6, 2023

This change is Reviewable

@EvyatarO EvyatarO requested a review from ArielElp July 6, 2023 13:04
@EvyatarO EvyatarO self-assigned this Jul 6, 2023
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EvyatarO)


api/starknet_trace_api_openrpc.json line 234 at r1 (raw file):

                    "SKIP_VALIDATE",
                    "SKIP_FEE_CHARGE",
                    "SKIP_EXECUTE"

remove this


api/starknet_trace_api_openrpc.json line 237 at r1 (raw file):

                ],
                "description": "Flags that indicate how to simulate a given transaction. The SKIP_FEE_CHARGE, false by default, will simulate also the fee charging phase"
            },

By default, the sequencer behavior is replicated locally (enough funds are expected to be in the account, and fee will be deducted from the balance before the simulation of the next transaction). To skip the fee charge, use the SKIP_FEE_CHARGE flag.

Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EvyatarO)

Copy link
Collaborator Author

@EvyatarO EvyatarO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp)


api/starknet_trace_api_openrpc.json line 234 at r1 (raw file):

Previously, ArielElp wrote…

remove this

Done.

Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EvyatarO)

@EvyatarO EvyatarO merged commit b02283a into master Jul 6, 2023
@EvyatarO EvyatarO deleted the update_simulate branch July 6, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants