Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change invoke v0: no nonce, add contract address #108

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

EvyatarO
Copy link
Collaborator

@EvyatarO EvyatarO commented Jul 6, 2023

This change is Reviewable

@EvyatarO EvyatarO requested a review from ArielElp July 6, 2023 11:35
@EvyatarO EvyatarO self-assigned this Jul 6, 2023
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @EvyatarO)


api/starknet_api_openrpc.json line 1858 at r1 (raw file):

                        "description": "The hash identifying the transaction"
                    },
                    "sender_address": {

you want to move back to contract_address here?

Copy link
Collaborator Author

@EvyatarO EvyatarO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArielElp and @EvyatarO)


api/starknet_api_openrpc.json line 1858 at r1 (raw file):

Previously, ArielElp wrote…

you want to move back to contract_address here?

Done.

Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EvyatarO)

@EvyatarO EvyatarO merged commit 504cd18 into master Jul 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants