Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: impl serialize config for chain info #98

Merged

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 25, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There is code duplication in the Chain info struct in the gateway. To solve this duplication, Chain info needs to implement serialize config.

What is the new behavior?

  • implement serialize config for blockifier chain info.

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Jul 25, 2024

@ArniStarkware ArniStarkware marked this pull request as ready for review July 25, 2024 11:14
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/mempool/code_dedup/chain_info/derive_serialize branch from b544021 to 8b24eca Compare July 31, 2024 06:55
@ArniStarkware ArniStarkware force-pushed the arni/mempool/code_dedup/chain_info/impl_serialize_config branch from 500504b to 847b344 Compare July 31, 2024 06:55
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Please upload report for BASE (arni/mempool/code_dedup/chain_info/derive_serialize@8b24eca). Learn more about missing BASE report.

Files Patch % Lines
crates/blockifier/src/context.rs 0.00% 32 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                   @@
##             arni/mempool/code_dedup/chain_info/derive_serialize      #98   +/-   ##
======================================================================================
  Coverage                                                       ?   76.63%           
======================================================================================
  Files                                                          ?      311           
  Lines                                                          ?    34391           
  Branches                                                       ?    34391           
======================================================================================
  Hits                                                           ?    26354           
  Misses                                                         ?     5748           
  Partials                                                       ?     2289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

ArniStarkware commented Jul 31, 2024

Merge activity

@ArniStarkware ArniStarkware changed the base branch from arni/mempool/code_dedup/chain_info/derive_serialize to main July 31, 2024 08:25
@ArniStarkware ArniStarkware force-pushed the arni/mempool/code_dedup/chain_info/impl_serialize_config branch from 847b344 to 00f65ba Compare July 31, 2024 08:26
@ArniStarkware ArniStarkware merged commit 0c58537 into main Jul 31, 2024
23 of 24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
@ArniStarkware ArniStarkware deleted the arni/mempool/code_dedup/chain_info/impl_serialize_config branch August 13, 2024 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants