-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: impl serialize config for chain info #98
chore: impl serialize config for chain info #98
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
b544021
to
8b24eca
Compare
500504b
to
847b344
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arni/mempool/code_dedup/chain_info/derive_serialize #98 +/- ##
======================================================================================
Coverage ? 76.63%
======================================================================================
Files ? 311
Lines ? 34391
Branches ? 34391
======================================================================================
Hits ? 26354
Misses ? 5748
Partials ? 2289 ☔ View full report in Codecov by Sentry. |
Merge activity
|
847b344
to
00f65ba
Compare
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
There is code duplication in the Chain info struct in the gateway. To solve this duplication, Chain info needs to implement serialize config.
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is