chore(mempool_infra): wrap serde operations with generic custom struc…

[Itay-Tsabary-Starkware]

…t towards binary serde

commit-id:325d0501

---

Stack:

• chore(mempool_infra): wrap serde operations with generic custom struc… #904 ⬅
• feat(mempool_infra): add serde utils #907

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.970 ms 67.116 ms 67.309 ms]
change: [-9.4722% -6.1111% -3.0439%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe

[codecov]

Codecov Report

Attention: Patch coverage is 70.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 29.38%. Comparing base (b0cfe82) to head (0426588).
Report is 35 commits behind head on main.

Files with missing lines	Patch %	Lines
...ensus_manager_types/src/consensus_manager_types.rs	0.00%	4 Missing ⚠️
crates/mempool_types/src/communication.rs	0.00%	3 Missing ⚠️
crates/batcher_types/src/communication.rs	0.00%	2 Missing ⚠️
...rates/consensus_manager_types/src/communication.rs	0.00%	2 Missing ⚠️
crates/mempool_infra/src/serde_utils.rs	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #904       +/-   ##
===========================================
- Coverage   74.18%   29.38%   -44.81%     
===========================================
  Files         359      137      -222     
  Lines       36240    12971    -23269     
  Branches    36240    12971    -23269     
===========================================
- Hits        26886     3811    -23075     
- Misses       7220     8885     +1665     
+ Partials     2134      275     -1859     

Flag	Coverage Δ
	29.38% <70.00%> (-44.81%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.964 ms 67.078 ms 67.206 ms]
change: [-9.5129% -6.0462% -2.9713%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
7 (7.00%) high mild
4 (4.00%) high severe

[lev-starkware]

Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/gateway_types/src/communication.rs line 81 at r1 (raw file):

//         }
//     }
// }

If this code is not needed, it is better to delete it.

Code quote:

// #[async_trait]
// impl GatewayClient for RemoteGatewayClientImpl {
//     #[instrument(skip(self))]
//     async fn add_tx(&self, gateway_input: GatewayInput) -> GatewayClientResult<TransactionHash> {
//         let request = GatewayRequest::AddTransaction(gateway_input);
//         let response = self.send(request).await?;
//         match response {
//             GatewayResponse::AddTransaction(Ok(response)) => Ok(response),
//             GatewayResponse::AddTransaction(Err(response)) => {
//                 Err(GatewayClientError::GatewayError(response))
//             }
//         }
//     }
// }

---

crates/mempool_infra/src/component_client/remote_component_client.rs line 82 at r1 (raw file):

impl<Request, Response> RemoteComponentClient<Request, Response>
where
    Request: Serialize + DeserializeOwned + std::fmt::Debug + Clone,

Add "use std::fmt::Debug" as per other modules.

Code quote:

std::fmt::Debug

---

crates/mempool_infra/src/component_server/remote_component_server.rs line 112 at r1 (raw file):

impl<Request, Response> RemoteComponentServer<Request, Response>
where
    Request: Serialize + DeserializeOwned + std::fmt::Debug + Send + Sync + 'static,

Add "use std::fmt::Debug" as per other modules.

Code quote:

std::fmt::Debug

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @lev-starkware)

---

crates/gateway_types/src/communication.rs line 81 at r1 (raw file):

Previously, lev-starkware wrote…

If this code is not needed, it is better to delete it.

Done.

---

crates/mempool_infra/src/component_client/remote_component_client.rs line 82 at r1 (raw file):

Previously, lev-starkware wrote…

Add "use std::fmt::Debug" as per other modules.

Done.

---

crates/mempool_infra/src/component_server/remote_component_server.rs line 112 at r1 (raw file):

Previously, lev-starkware wrote…

Add "use std::fmt::Debug" as per other modules.

Done.

[lev-starkware]

Reviewed 6 of 13 files at r1, 3 of 6 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: 12 of 13 files reviewed, 3 unresolved discussions

[Itay-Tsabary-Starkware]

Reviewed 6 of 13 files at r1, 4 of 6 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.255 ms 66.342 ms 66.439 ms]
change: [-8.3249% -4.3125% -1.0063%] (p = 0.01 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high severe