-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): unify get entry point for all contract classes #900
chore(blockifier): unify get entry point for all contract classes #900
Conversation
# Conflicts: # crates/blockifier/src/execution/syscalls/syscalls_test.rs
…-engine # Conflicts: # Cargo.lock
…cution-engine # Conflicts: # Cargo.lock
…cution-engine # Conflicts: # Cargo.lock # crates/blockifier/src/execution/contract_class.rs
7a4d4ad
to
e35dc60
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## native/add-native-execution-engine #900 +/- ##
=====================================================================
Coverage ? 74.38%
=====================================================================
Files ? 367
Lines ? 38657
Branches ? 38657
=====================================================================
Hits ? 28754
Misses ? 7576
Partials ? 2327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
86f9e9e
to
236afd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion
crates/blockifier/src/execution/contract_class.rs
line 65 at r2 (raw file):
} #[derive(Clone)]
I am not sure an enum is the right solution here.
236afd6
to
f2ff7f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 14 files reviewed, 2 unresolved discussions
crates/blockifier/src/execution/contract_class.rs
line 118 at r3 (raw file):
} pub fn entry_points_of_same_type(&self, entry_point_type: EntryPointType) -> Vec<EntryPoint> {
This function is a bit expensive. Also, the name is a bit confusing because ContractClass::V0() also has an entry_points_of_same_type file, and calling this function with ContractClass::V0() will result in panic.
ceeeaa4
to
9a9e4bb
Compare
This change is