Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): add ProposalParts and related objects #898

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Sep 19, 2024

This PR adds ProposalParts which is an enum that can be ProposalInit, Transactions, or ProposalFin.
This will be the content that we stream whenever Consensus wants to make a new proposal.


This change is Reviewable

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 86.25592% with 29 lines in your changes missing coverage. Please review.

Project coverage is 74.42%. Comparing base (693d1df) to head (dfa7bfc).
Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
...rates/papyrus_protobuf/src/converters/consensus.rs 76.19% 9 Missing and 6 partials ⚠️
...sequencing/papyrus_consensus/src/stream_handler.rs 90.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   76.04%   74.42%   -1.62%     
==========================================
  Files         359      358       -1     
  Lines       38298    36434    -1864     
  Branches    38298    36434    -1864     
==========================================
- Hits        29122    27117    -2005     
- Misses       6841     7173     +332     
+ Partials     2335     2144     -191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant