Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): remove duplicate get_tip_resource_bounds_hash … #888

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Sep 19, 2024

…implementation


This change is Reviewable

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (1ad069a) to head (a7efd95).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   74.29%   74.27%   -0.02%     
==========================================
  Files         358      358              
  Lines       36280    36255      -25     
  Branches    36280    36255      -25     
==========================================
- Hits        26953    26928      -25     
- Misses       7188     7190       +2     
+ Partials     2139     2137       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware changed the title chore(papyrus_common): remove duplicate get_tip_resource_bounds_hash … chore(common): remove duplicate get_tip_resource_bounds_hash … Sep 19, 2024
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.475 ms 66.985 ms 67.772 ms]
change: [-8.3678% -5.1039% -2.2557%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high severe

Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [67.306 ms 69.551 ms 72.270 ms]
change: [+1.2024% +4.3931% +7.4817%] (p = 0.02 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
2 (2.00%) high mild
12 (12.00%) high severe

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit 3634605 into main Sep 22, 2024
27 checks passed
@dorimedini-starkware dorimedini-starkware deleted the dori/remove-dup branch September 22, 2024 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants