Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockifier): enforce fee for allresourcebounds when l1 gas is 0 #846

Merged
merged 3 commits into from
Sep 24, 2024

fix(blockifier): enforce fee for allresourcebounds when l1 gas is 0

641d5ce
Select commit
Loading
Failed to load commit list.
Merged

fix(blockifier): enforce fee for allresourcebounds when l1 gas is 0 #846

fix(blockifier): enforce fee for allresourcebounds when l1 gas is 0
641d5ce
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2024 in 0s

75.52% (+1.33%) compared to b0cfe82

View this Pull Request on Codecov

75.52% (+1.33%) compared to b0cfe82

Details

Codecov Report

Attention: Patch coverage is 84.37500% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.52%. Comparing base (b0cfe82) to head (641d5ce).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/versioned_constants.rs 52.94% 8 Missing ⚠️
crates/blockifier/src/transaction/objects.rs 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
+ Coverage   74.18%   75.52%   +1.33%     
==========================================
  Files         359       87     -272     
  Lines       36240    11120   -25120     
  Branches    36240    11120   -25120     
==========================================
- Hits        26886     8398   -18488     
+ Misses       7220     2311    -4909     
+ Partials     2134      411    -1723     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.