chore(blockifier): have limit_steps_by_resources flag rep charge_fee flag and enforce_fee ret val

[avivg-starkware]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.35%. Comparing base (7dd6541) to head (cf3b295).

Additional details and impacted files

@@                                  Coverage Diff                                  @@
##           avivg/blockifier/combine_charge_fee_w_enforce_fee     #833      +/-   ##
=====================================================================================
+ Coverage                                              70.43%   74.35%   +3.91%     
=====================================================================================
  Files                                                     88      358     +270     
  Lines                                                  11094    36238   +25144     
  Branches                                               11094    36238   +25144     
=====================================================================================
+ Hits                                                    7814    26943   +19129     
- Misses                                                  2891     7155    +4264     
- Partials                                                 389     2140    +1751     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.310 ms 66.396 ms 66.493 ms]
change: [-2.9615% -1.9610% -1.0823%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

[meship-starkware]

Reviewed 1 of 2 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)

---

crates/blockifier/src/blockifier/stateful_validator.rs line 118 at r2 (raw file):

        let tx_context = Arc::new(self.tx_executor.block_context.to_tx_context(tx));

        let limit_steps_by_resources =  tx.create_tx_info().enforce_fee(); //aviv: was true;

Remove all aviv comments.

---

crates/blockifier/src/concurrency/worker_logic.rs line 30 at r2 (raw file):

    TransactionInfoCreator,
};

Revert this change.

[meship-starkware]

Reviewed 1 of 2 files at r3, all commit messages.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

[meship-starkware]

Reviewed 11 of 14 files at r4, all commit messages.
Reviewable status: 11 of 14 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)