Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(consensus): move fee_market to concensus #2977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayeletstarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ayeletstarkware ayeletstarkware marked this pull request as ready for review December 26, 2024 09:22
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ayeletstarkware ayeletstarkware force-pushed the ayelet/consensus/relocate-fee-market branch from a6e4d27 to 0942ae2 Compare December 26, 2024 09:52
@ayeletstarkware ayeletstarkware force-pushed the ayelet/consensus/relocate-fee-market branch from 0942ae2 to eedeb13 Compare December 26, 2024 11:24
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ayeletstarkware)


crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs line 15 at r2 (raw file):

pub mod cende;

/// Fee market logic.

No need if it's just repeating the name of the module.

Code quote:

/// Fee market logic.

crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs line 16 at r2 (raw file):

/// Fee market logic.
#[allow(missing_docs)]

What is this?

Code quote:

#[allow(missing_docs)]

crates/sequencing/papyrus_consensus_orchestrator/src/fee_market_logic/mod.rs line 1 at r2 (raw file):

pub mod fee_market;

The module is fee_market_logic, no need to declare another module here.
Also, move all the content of fee_market.rs here. You can rename fee_market_logic -> fee_market.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants