Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(papyrus_node): use printing util in papyrus node config test #2972

Open
wants to merge 1 commit into
base: arni/infra/config_test/print
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware
Copy link
Contributor Author

crates/papyrus_config/src/lib.rs line 73 at r1 (raw file):

pub mod loading;
pub mod presentation;
#[cfg(test)]

I do not understand why I need to delete this for the import to work...

Code quote:

#[cfg(test)]

@ArniStarkware ArniStarkware force-pushed the arni/infra/config_test/print branch from 37c5fa4 to 5965481 Compare December 25, 2024 17:54
@ArniStarkware ArniStarkware force-pushed the arni/infra/config_test/use_in_papyrus_config_test branch from 61d27b5 to 0655a83 Compare December 25, 2024 17:55
@ArniStarkware ArniStarkware force-pushed the arni/infra/config_test/print branch from 5965481 to 084a448 Compare December 26, 2024 09:30
@ArniStarkware ArniStarkware force-pushed the arni/infra/config_test/use_in_papyrus_config_test branch from 0655a83 to 07bc96d Compare December 26, 2024 09:30
Copy link

Artifacts upload workflows:

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r2.
Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants