chore: rename create_config function #2959
Open
+31
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 25, 2024
|
This change is |
nadin-Starkware
force-pushed
the
spr/main/9b08c150
branch
from
a2f08c4 to
a328eea
Compare
nadin-Starkware
force-pushed
the
spr/main/895293ba
branch
from
19d4bb8 to
9d7f285
Compare
nadin-Starkware
force-pushed
the
spr/main/9b08c150
branch
2 times, most recently
from
ea72845 to
5a4f75f
Compare
nadin-Starkware
force-pushed
the
spr/main/895293ba
branch
from
9d7f285 to
bff6728
Compare
Itay-Tsabary-Starkware
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
nadin-Starkware
force-pushed
the
spr/main/9b08c150
branch
from
5a4f75f to
f24d450
Compare
nadin-Starkware
force-pushed
the
spr/main/895293ba
branch
2 times, most recently
from
d6cf6cf to
f8e25d9
Compare
nadin-Starkware
force-pushed
the
spr/main/9b08c150
branch
from
f24d450 to
9fe56cb
Compare
nadin-Starkware
force-pushed
the
spr/main/9b08c150
branch
from
9fe56cb to
4a05e4f
Compare
commit-id:819513bb
commit-id:9b08c150
nadin-Starkware
force-pushed
the
spr/main/9b08c150
branch
from
4a05e4f to
29e3253
Compare
auto-merge was automatically disabled
December 25, 2024 15:55
Merge commits are not allowed on this repository
nadin-Starkware
commented
Dec 26, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-id:9b08c150
Stack: