Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(papyrus_base_layer): start implementing eth events api #2933

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(papyrus_base_layer): start implementing eth events api #2933

wants to merge 1 commit into from
+112 −13

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

  • Currently only implementing the simplest event to parse, the rest are
    coming up.
  • removed two unused error variants: FeltParseError, Serde

@Itay-Tsabary-Starkware
feat(papyrus_base_layer): start implementing eth events api
6b5a16d 
- Currently only implementing the simplest event to parse, the rest are
  coming up.
- removed two unused error variants: `FeltParseError`, `Serde`

commit-id:4ac87535
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware mentioned this pull request Dec 25, 2024
Open
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

Artifacts upload workflows:

@github-actions GitHub Actions
Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.231 ms 30.293 ms 30.358 ms]
change: [+1.7153% +2.0141% +2.2956%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Itay-Tsabary-Starkware @reviewable-StarkWare