refactor(papyrus_state_reader): code cleanup + caching with sierra only if native flag is on #2926
Conversation
|
This change is |
noaov1
force-pushed
the
noa/refactor_papyrus_state
branch
from
77bcf56 to
c9ea09f
Compare
noaov1
changed the title
noaov1
force-pushed
the
noa/refactor_papyrus_state
branch
from
c9ea09f to
cbb09a4
Compare
noaov1
changed the title
noaov1
force-pushed
the
noa/refactor_papyrus_state
branch
2 times, most recently
from
7f46c96 to
73a191d
Compare
noaov1
changed the title
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1)
There was a problem hiding this comment.
Reviewable status:
|
Suggestion: CachedCasm::WithoutSierra(runnable_casm) |
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)
…ly if native flag is on
noaov1
force-pushed
the
noa/refactor_papyrus_state
branch
from
73a191d to
ab2dad5
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @avi-starkware)
crates/papyrus_state_reader/src/papyrus_state.rs line 84 at r1 (raw file):
#[cfg(feature = "cairo_native")] let cached_casm = if !self.contract_class_manager.run_cairo_native() { CachedCasm::WithoutSierra(runnable_casm);
Nice! I wonder how come the the build with native feature flag was completed successfully.
Done.
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
No description provided.