Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): add try_sync to context API #2924

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

asmaastarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 24, 2024

Artifacts upload workflows:

@asmaastarkware asmaastarkware force-pushed the asmaa/sync_timeout_duration branch from 7509732 to 47282a4 Compare December 25, 2024 06:14
@asmaastarkware asmaastarkware changed the title feat(consensus): add try_sync to context, and implement it in sequencer feat(consensus): add try_sync to context API Dec 25, 2024
Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)

Base automatically changed from asmaa/sync_timeout_duration to main December 25, 2024 14:06
Copy link
Contributor Author

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)

@asmaastarkware asmaastarkware added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit 371eccb Dec 25, 2024
16 of 26 checks passed
@asmaastarkware asmaastarkware deleted the asmaa/try_sync branch December 25, 2024 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants