feat(consensus): add declare transaction for cende

[Yael-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Yael-Starkware]

• feat(consensus): add declare transaction for cende #2921 : 2 dependent PRs (#2988 , #3039 ) 👈 (View in Graphite)
• feat(sequencing): add cetral deploy account transaction written object #2872
• feat(consensus): add central invoke transaction #2861
• feat(consensus): add CentralStateDiff object in the aerospike format #2715
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.699 ms 35.161 ms 35.710 ms]
change: [+1.2372% +2.6553% +4.3054%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
4 (4.00%) high mild
10 (10.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.662 ms 35.163 ms 35.757 ms]
change: [+1.5239% +2.9734% +4.8646%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) high mild
8 (8.00%) high severe

[dafnamatsry]

Reviewed 1 of 3 files at r1, 1 of 3 files at r2, all commit messages.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @DvirYo-starkware and @Yael-Starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 120 at r3 (raw file):

}

impl From<CentralSierraVersion> for (String, String, String) {

Where is this being used?

---

crates/starknet_api/src/executable_transaction.rs line 162 at r3 (raw file):

        (account_deployment_data, AccountDeploymentData),
        (compiled_class_hash, CompiledClassHash),
        (resource_bounds, ValidResourceBounds)

Note that you are adding here getters for all tx versionsm that panics for versions that don't have those field.
I think it is fine but at least worth documenting it.
Or add a similar implement_v3_tx_getters! as done in the inner transaction types.

Code quote:

        (tip, Tip),
        (nonce_data_availability_mode, DataAvailabilityMode),
        (fee_data_availability_mode, DataAvailabilityMode),
        (paymaster_data, PaymasterData),
        (account_deployment_data, AccountDeploymentData),
        (compiled_class_hash, CompiledClassHash),
        (resource_bounds, ValidResourceBounds)

[Yael-Starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 120 at r3 (raw file):

Previously, dafnamatsry wrote…

Where is this being used?

when serializing this object, it needs to be serialized as a hex string.

---

crates/starknet_api/src/executable_transaction.rs line 162 at r3 (raw file):

Previously, dafnamatsry wrote…

Note that you are adding here getters for all tx versionsm that panics for versions that don't have those field.
I think it is fine but at least worth documenting it.
Or add a similar implement_v3_tx_getters! as done in the inner transaction types.

Done.

[dafnamatsry]

Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @DvirYo-starkware and @Yael-Starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 120 at r3 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

when serializing this object, it needs to be serialized as a hex string.

So why do we need this object (CentralSierraVersion) at all if we convert it to string tuple?
You can define the sierra_version directly as (String, String, String), and implement From<SierraVersion> for (String, String, String)

---

crates/starknet_api/src/executable_transaction.rs line 172 at r5 (raw file):

        (account_deployment_data, AccountDeploymentData),
        (resource_bounds, ValidResourceBounds)
    );

Suggestion:

    implement_inner_tx_getter_calls!(
        (class_hash, ClassHash),
        (nonce, Nonce),
        (sender_address, ContractAddress),
        (signature, TransactionSignature),
        (version, TransactionVersion),
        
        // compiled_class_hash is only supported in V2 and V3, otherwise the getter panics.
        (compiled_class_hash, CompiledClassHash),
        
        // The following fields are only supported in V3, otherwise the getter panics.
        (tip, Tip),
        (nonce_data_availability_mode, DataAvailabilityMode),
        (fee_data_availability_mode, DataAvailabilityMode),
        (paymaster_data, PaymasterData),
        (account_deployment_data, AccountDeploymentData),
        (resource_bounds, ValidResourceBounds)
    );

[Yael-Starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 120 at r3 (raw file):

Previously, dafnamatsry wrote…

So why do we need this object (CentralSierraVersion) at all if we convert it to string tuple?
You can define the sierra_version directly as (String, String, String), and implement From<SierraVersion> for (String, String, String)

can't impl From in this file due to rust orphan rule.
but I defined my own into_string_tuple function instead.

---

crates/starknet_api/src/executable_transaction.rs line 172 at r5 (raw file):

        (account_deployment_data, AccountDeploymentData),
        (resource_bounds, ValidResourceBounds)
    );

can't add blank lines here due to auto-formatting

[Yael-Starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 120 at r3 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

can't impl From in this file due to rust orphan rule.
but I defined my own into_string_tuple function instead.

done.

[dafnamatsry]

Reviewed 1 of 3 files at r2, 1 of 2 files at r4, 1 of 2 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)

[dafnamatsry]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)