feat: reinstate rustfmt script, detach from CI #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladchase
requested review from
ilyalesokhin-starkware and
dorimedini-starkware
|
This change is |
giladchase
force-pushed
the
gilad/rust-fmt
branch
from
16695f1 to
4f0a3c7
Compare
dorimedini-starkware
requested changes
Dec 24, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @giladchase and @ilyalesokhin-starkware)
a discussion (no related file):
rebase over main-v0.13.4
giladchase
force-pushed
the
gilad/rust-fmt
branch
from
4f0a3c7 to
3c225ac
Compare
giladchase
commented
Dec 24, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @ilyalesokhin-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
rebase over
main-v0.13.4
:done:
|
Artifacts upload workflows: |
dorimedini-starkware
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this doesn't necessarily have to be checked-in here, I think this kind of thing can be inside the dev-tools wiki