-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(papyrus_storage): add revert_events function that removes the events of a block #2905
base: alonl/event_storage_split
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare)
crates/papyrus_storage/src/body/events.rs
line 450 at r5 (raw file):
let events_table = self.open_table(&self.tables.events)?; let file_offset_table = self.open_table(&self.tables.file_offsets)?; let address_to_tx_index_table = self.open_table(&self.tables.address_to_tx_index)?;
Squash this with the previous PR so it will be valid
324b577
to
9ac0fe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)
crates/papyrus_storage/src/body/events.rs
line 450 at r5 (raw file):
Previously, ShahakShama wrote…
Squash this with the previous PR so it will be valid
Fixed during rebasing
Benchmark movements: |
9ac0fe0
to
d2e731c
Compare
No description provided.