Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(papyrus_storage): add revert_events function that removes the events of a block #2905

Open
wants to merge 4 commits into
base: alonl/event_storage_split
Choose a base branch
from

Conversation

AlonLStarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AlonLStarkWare AlonLStarkWare changed the title refactor(papyrus_storage): add revert_events function that removes the references to the events of a block refactor(papyrus_storage): add revert_events function that removes the events of a block Dec 23, 2024
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare)


crates/papyrus_storage/src/body/events.rs line 450 at r5 (raw file):

            let events_table = self.open_table(&self.tables.events)?;
            let file_offset_table = self.open_table(&self.tables.file_offsets)?;
            let address_to_tx_index_table = self.open_table(&self.tables.address_to_tx_index)?;

Squash this with the previous PR so it will be valid

Copy link
Contributor Author

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)


crates/papyrus_storage/src/body/events.rs line 450 at r5 (raw file):

Previously, ShahakShama wrote…

Squash this with the previous PR so it will be valid

Fixed during rebasing

Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.599 ms 35.067 ms 35.619 ms]
change: [+1.0970% +2.6247% +4.3763%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants