chore(blockifier): add feild channel_size to contract_class_manager_config #2902
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
avivg-starkware
force-pushed
the
avivg/blockifier/add_channel_size_to_contact_manager_config
branch
2 times, most recently
from
7868dcc to
7da8920
Compare
|
Suggestion: pub const DEFAULT_COMPILATION_REQUEST_CHANNEL_SIZE: usize = 1000; |
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1)
avivg-starkware
force-pushed
the
avivg/blockifier/add_channel_size_to_contact_manager_config
branch
3 times, most recently
from
9c10bca to
0adfb8c
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)
crates/blockifier/src/state/contract_class_manager.rs line 31 at r1 (raw file):
use crate::state::global_cache::{CachedCasm, ContractCaches}; pub const CHANNEL_SIZE: usize = 1000;
Done.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @avivg-starkware)
crates/blockifier/src/state/contract_class_manager.rs line 96 at r2 (raw file):
} let (sender, receiver) = sync_channel(DEFAULT_COMPILATION_REQUEST_CHANNEL_SIZE);
Suggestion:
let (sender, receiver) = sync_channel(config.channel_size);
avivg-starkware
force-pushed
the
avivg/blockifier/add_channel_size_to_contact_manager_config
branch
from
0adfb8c to
e39a328
Compare
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @noaov1)
crates/blockifier/src/state/contract_class_manager.rs line 96 at r2 (raw file):
} let (sender, receiver) = sync_channel(DEFAULT_COMPILATION_REQUEST_CHANNEL_SIZE);
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware and @noaov1)
crates/blockifier/src/state/contract_class_manager.rs line 129 at r3 (raw file):
"Compilation request channel is full (size: {}). Compilation request for \ class hash {} was not sent.", DEFAULT_COMPILATION_REQUEST_CHANNEL_SIZE,
Suggestion:
self.config.channel_size
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)
There was a problem hiding this comment.
Please rebase over main-13.4
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)
avivg-starkware
force-pushed
the
avivg/blockifier/add_channel_size_to_contact_manager_config
branch
from
e39a328 to
19dab86
Compare
There was a problem hiding this comment.
Done
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware)
crates/blockifier/src/state/contract_class_manager.rs line 129 at r3 (raw file):
"Compilation request channel is full (size: {}). Compilation request for \ class hash {} was not sent.", DEFAULT_COMPILATION_REQUEST_CHANNEL_SIZE,
Done.
avivg-starkware
force-pushed
the
avivg/blockifier/add_channel_size_to_contact_manager_config
branch
from
19dab86 to
87a8788
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_channel_size_to_contact_manager_config
branch
from
87a8788 to
b7e2924
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware)
No description provided.