chore(blockifier): add log for cairo native execution #2868
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1)
crates/blockifier/src/execution/execution_utils.rs line 139 at r1 (raw file):
) } else { log::info!("Using Cairo Native execution.");
Let's log this at DEBUG level because there will be a lot of these messages and we want to be able to not see them.
+
Let add the block id and transaction hash to the message, so that we know what the message is referring to.
Suggestion:
log::debug!("Using Cairo Native execution.");
avivg-starkware
force-pushed
the
avivg/blockifier/add_log_native_execution
branch
from
4c4c2e9 to
2355384
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)
crates/blockifier/src/execution/execution_utils.rs line 139 at r1 (raw file):
Previously, avi-starkware wrote…
Let's log this at DEBUG level because there will be a lot of these messages and we want to be able to not see them.
+
Let add the block id and transaction hash to the message, so that we know what the message is referring to.
Done.
Making sure I'm not mistaken- by Block ID, you mean "block_number" ?
Code snippet:
context.tx_context.block_context.block_info.block_number
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1)
crates/blockifier/src/execution/execution_utils.rs line 139 at r1 (raw file):
Previously, avivg-starkware wrote…
Done.
Making sure I'm not mistaken- by Block ID, you mean "block_number" ?
Yes. Call it block number in the message instead of block ID to avoid confusion.
avivg-starkware
force-pushed
the
avivg/blockifier/add_log_native_execution
branch
from
2355384 to
4a4ac1c
Compare
|
Previously, avi-starkware wrote…
Done. thanks! |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware)
crates/blockifier/src/execution/execution_utils.rs line 139 at r1 (raw file):
Previously, avivg-starkware wrote…
Done. thanks!
Nice. Could you please add the class hash as well? (A transaction can run multiple classes.)
avivg-starkware
force-pushed
the
avivg/blockifier/add_log_native_execution
branch
from
4a4ac1c to
5bbb9f5
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)
crates/blockifier/src/execution/execution_utils.rs line 139 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Nice. Could you please add the class hash as well? (A transaction can run multiple classes.)
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)
There was a problem hiding this comment.
Reviewable status:
avivg-starkware
force-pushed
the
avivg/blockifier/add_log_native_execution
branch
from
5bbb9f5 to
12585c8
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:
avivg-starkware
deleted the
avivg/blockifier/add_log_native_execution
branch
No description provided.