chore(starknet_l1_provider): add fake l1 provider client

[giladchase]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-20T21:43:17Z
• Started at 2024-12-24T14:02:18Z

[elintul]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @giladchase and @matan-starkware)

---

crates/starknet_l1_provider/src/test_utils.rs line 138 at r1 (raw file):

#[derive(Default)]
pub struct FakeL1ProviderClient {

Are we using "fake" throughout the codebase? Maybe "mock" is better?
Consistency is more important though.

Code quote:

Fake

---

crates/starknet_l1_provider/src/test_utils.rs line 139 at r1 (raw file):

#[derive(Default)]
pub struct FakeL1ProviderClient {
    pub events_received: Mutex<Vec<Event>>,

Why? Is it accessed concurrently?

Code quote:

Mutex

---

crates/starknet_l1_provider/src/test_utils.rs line 145 at r1 (raw file):

    #[track_caller]
    pub fn assert_add_events_received_with(&self, expected: &[Event]) {
        assert_eq!(self.events_received.lock().unwrap().drain(..).collect_vec(), expected);

Noice.

Code quote:

.drain(..)

---

crates/starknet_l1_provider/src/test_utils.rs line 161 at r1 (raw file):

        Ok(())
    }
    async fn validate(

Suggestion:

    }
    
    async fn add_events(&self, events: Vec<Event>) -> L1ProviderClientResult<()> {
        self.events_received.lock().unwrap().extend(events);
        Ok(())
    }
    
    async fn validate(

[elintul]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @giladchase and @matan-starkware)