chore(cairo_native): update cairo native version to 0.2.5-rc1 #2839

meship-starkware · 2024-12-19T16:34:31Z

No description provided.

reviewable-StarkWare · 2024-12-19T16:34:40Z

This change is

github-actions · 2024-12-19T16:36:12Z

Artifacts upload workflows:

meship-starkware

Reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, all discussions resolved

meship-starkware

Reviewed 1 of 3 files at r2.
Reviewable status: 1 of 6 files reviewed, all discussions resolved

meship-starkware

Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion

crates/bin/starknet-native-compile/Cargo.lock line 471 at r2 (raw file):

]

[[package]]

This cargo.lock file did not update, so I ran cargo update inside the folder and only accepted the relevant changes. I think it might be risky.

noaov1

Reviewed 2 of 5 files at r1, 2 of 3 files at r3, all commit messages.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @meship-starkware)

crates/bin/starknet-native-compile/Cargo.lock line 471 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

This cargo.lock file did not update, so I ran cargo update inside the folder and only accepted the relevant changes. I think it might be risky.

Why wasn't it updated?

Cargo.toml line 106 at r3 (raw file):

cairo-lang-utils = "2.9.2"
# Important: when updated, make sure to update the cairo-native submodule as well.
cairo-native = "0.2.5-rc1"

Update the submodule?

Code quote:

# Important: when updated, make sure to update the cairo-native submodule as well.
cairo-native = "0.2.5-rc1"

meship-starkware

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @noaov1)

Cargo.toml line 106 at r3 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Update the submodule?

I did update it but it seems like I cant push it for some reason :(

crates/bin/starknet-native-compile/Cargo.lock line 471 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why wasn't it updated?

I am not sure. I think that it is only updated through cargo update or when you run a code that uses the cargo.toml packages. I only run the tests, so this might be the issue.

noaov1

Reviewed 1 of 3 files at r2, 1 of 3 files at r3, 5 of 5 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)

crates/bin/starknet-native-compile/Cargo.lock line 471 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

I am not sure. I think that it is only updated through cargo update or when you run a code that uses the cargo.toml packages. I only run the tests, so this might be the issue.

Try building the crate/cargo update?

-- commits line 2 at r5:
Please add to the commit message the update of the compiler version.

Code quote:

- e0d1baf: chore(cairo_native): update cairo native version to 0.2.5-rc2

noaov1

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)

github-actions · 2024-12-29T12:15:28Z

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.070 ms 30.114 ms 30.159 ms]
change: [+1.0801% +1.3014% +1.5031%] (p = 0.00 < 0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

github-actions · 2024-12-29T14:12:17Z

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.089 ms 35.554 ms 36.106 ms]
change: [+2.6544% +4.0820% +5.6648%] (p = 0.00 < 0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) high mild
9 (9.00%) high severe

github-actions · 2024-12-30T12:07:49Z

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.327 ms 30.385 ms 30.456 ms]
change: [+2.3218% +2.5584% +2.8032%] (p = 0.00 < 0.05)
Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe

github-actions · 2024-12-30T12:39:30Z

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.353 ms 30.403 ms 30.457 ms]
change: [+1.8885% +2.3510% +2.7256%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe

github-actions · 2025-01-01T13:58:53Z

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.301 ms 30.335 ms 30.369 ms]
change: [+2.0083% +2.3194% +2.5791%] (p = 0.00 < 0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

meship-starkware

Reviewable status: 34 of 39 files reviewed, 3 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)

crates/bin/starknet-native-compile/Cargo.lock line 471 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Try building the crate/cargo update?

You need to do cargo update inside the starknet-native-compile crate

crates/blockifier/feature_contracts/cairo1/sierra/cairo_steps_test_contract.sierra.json line 4 at r9 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why was it changed? Isn't the compiler version for this contract fixed?

From what Tzahi told me, it was 0x6, but AvivY changed it manually to 0x5 so the test would pass

github-actions · 2025-01-01T16:25:51Z

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.169 ms 34.204 ms 34.241 ms]
change: [-5.2464% -3.6284% -2.1969%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high mild

meship-starkware

Reviewed 1 of 5 files at r9, 1 of 4 files at r24.
Reviewable status: 30 of 39 files reviewed, 3 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)

crates/blockifier/src/execution/execution_utils.rs line 61 at r16 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Delete?

Done.

noaov1

Reviewed 1 of 4 files at r19, 2 of 7 files at r21, 1 of 1 files at r23, 4 of 4 files at r24, 2 of 2 files at r27, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yoni-Starkware)

.github/workflows/upload_artifacts_workflow.yml line 102 at r27 (raw file):

      # Build artifact.
      - uses: ./.github/actions/bootstrap

We don't need it anymore?
@dorimedini-starkware

Code quote:

      - uses: ./.github/actions/bootstrap

dorimedini-starkware

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

.github/workflows/upload_artifacts_workflow.yml line 102 at r27 (raw file):

Previously, noaov1 (Noa Oved) wrote…

We don't need it anymore?
@dorimedini-starkware

I think it's contained in build_native_in_docker... read the contents of the bootstrap action (and the setup_native_deps action it uses) and make sure the sequencer dockerfile does the same?

noaov1

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)

.github/workflows/upload_artifacts_workflow.yml line 102 at r27 (raw file):

Previously, dorimedini-starkware wrote…

I think it's contained in build_native_in_docker... read the contents of the bootstrap action (and the setup_native_deps action it uses) and make sure the sequencer dockerfile does the same?

From a short glimpse it seems that it is not the same (but maybe I'm missing something).
The bootstrap script contains 3 actions:

Update the git submodule. Done in the build_native_blockifier.sh, so all good.
Install rust. I did not see any mentioned for that in build_native_in_docker.sh or build_native_blockifier.sh
Install cairo native. Same.

But, I may be missing something and thought you might know.

dorimedini-starkware

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

.github/workflows/upload_artifacts_workflow.yml line 102 at r27 (raw file):

Previously, noaov1 (Noa Oved) wrote…

From a short glimpse it seems that it is not the same (but maybe I'm missing something).
The bootstrap script contains 3 actions:

Update the git submodule. Done in the build_native_blockifier.sh, so all good.

Install rust. I did not see any mentioned for that in build_native_in_docker.sh or build_native_blockifier.sh

Install cairo native. Same.

But, I may be missing something and thought you might know.

build_native_in_docker uses hte sequencer-ci docker
which calls install_build_tools
which has an install_rust function, that does

curl https://sh.rustup.rs -sSf | sh -s -- -y

… compiled to 2.10.0-rc.0

noaov1

Reviewed 1 of 18 files at r33, 2 of 4 files at r36, 2 of 13 files at r37, 1 of 11 files at r38, 1 of 11 files at r44.
Reviewable status: 23 of 40 files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

noaov1

Reviewed 1 of 13 files at r37, 3 of 4 files at r42, 3 of 4 files at r43, 10 of 11 files at r44, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yoni-Starkware)

crates/blockifier/src/execution/syscalls/syscall_tests/get_class_hash_at.rs line 44 at r44 (raw file):

        CallExecution {
            retdata: retdata!(),
            gas_consumed: REQUIRED_GAS_GET_CLASS_HASH_AT_TEST + redeposit_gas,

You can simply change the REQUIRED_GAS_GET_CLASS_HASH_AT_TEST, no? And set the redeposit_gas in the out of gas test to 600.

Code quote:

            gas_consumed: REQUIRED_GAS_GET_CLASS_HASH_AT_TEST + redeposit_gas,

noaov1

Reviewed 1 of 1 files at r45, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yoni-Starkware)

meship-starkware force-pushed the meship/update_cairo_native branch 3 times, most recently from 47dc68a to 1ce1d03 Compare December 19, 2024 16:42

meship-starkware commented Dec 19, 2024

View reviewed changes

meship-starkware force-pushed the meship/update_cairo_native branch from 1ce1d03 to e495b98 Compare December 22, 2024 07:49

meship-starkware commented Dec 22, 2024

View reviewed changes

meship-starkware requested a review from noaov1 December 22, 2024 10:25

meship-starkware force-pushed the meship/update_cairo_native branch from e495b98 to 0cc6f64 Compare December 22, 2024 10:37

noaov1 requested changes Dec 22, 2024

View reviewed changes

meship-starkware commented Dec 23, 2024

View reviewed changes

meship-starkware force-pushed the meship/update_cairo_native branch 3 times, most recently from 2e47414 to e0d1baf Compare December 29, 2024 09:50

meship-starkware changed the base branch from main to main-v0.13.4 December 29, 2024 09:51

noaov1 reviewed Dec 29, 2024

View reviewed changes

meship-starkware force-pushed the meship/update_cairo_native branch from e0d1baf to 35ffbee Compare December 29, 2024 11:23

noaov1 reviewed Dec 29, 2024

View reviewed changes

meship-starkware force-pushed the meship/update_cairo_native branch from 35ffbee to 54d5933 Compare December 29, 2024 12:04

meship-starkware force-pushed the meship/update_cairo_native branch 2 times, most recently from f2e2696 to 9940b83 Compare December 29, 2024 14:01

meship-starkware force-pushed the meship/update_cairo_native branch from 9940b83 to 227f114 Compare December 30, 2024 11:54

meship-starkware force-pushed the meship/update_cairo_native branch from 227f114 to a6ece8b Compare December 30, 2024 12:25

meship-starkware force-pushed the meship/update_cairo_native branch from a6ece8b to 46c9c8d Compare December 30, 2024 13:16

alon-dotan-starkware force-pushed the meship/update_cairo_native branch from 5a271b2 to 992c7c7 Compare January 1, 2025 13:45

meship-starkware requested a review from Yoni-Starkware January 1, 2025 13:48

meship-starkware commented Jan 1, 2025

View reviewed changes

alon-dotan-starkware force-pushed the meship/update_cairo_native branch 2 times, most recently from 096a8b1 to dcaca1a Compare January 1, 2025 16:06

meship-starkware force-pushed the meship/update_cairo_native branch 2 times, most recently from 09201e9 to 19858cd Compare January 1, 2025 17:12

meship-starkware commented Jan 1, 2025

View reviewed changes

noaov1 approved these changes Jan 2, 2025

View reviewed changes

dorimedini-starkware reviewed Jan 2, 2025

View reviewed changes

noaov1 approved these changes Jan 5, 2025

View reviewed changes

dorimedini-starkware reviewed Jan 5, 2025

View reviewed changes

meship-starkware force-pushed the meship/update_cairo_native branch 3 times, most recently from de7951a to 8246528 Compare January 6, 2025 07:58

meship-starkware and others added 5 commits January 6, 2025 10:01

chore(cairo_native): update cairo native version to 0.2.5-rc2 and the…

b007564

… compiled to 2.10.0-rc.0

chore: bump os version to ubuntu:24.04

378520b

fix: fix sierra gas differnce in new compiler

5934525

chore: support ubuntu 24.04

1f3ec78

fix: fix code style script

b7b941f

meship-starkware force-pushed the meship/update_cairo_native branch from 8246528 to 6702450 Compare January 6, 2025 08:03

noaov1 reviewed Jan 6, 2025

View reviewed changes

noaov1 approved these changes Jan 6, 2025

View reviewed changes

fix: fix gas cost in tests

bbcfa84

meship-starkware force-pushed the meship/update_cairo_native branch from 6702450 to bbcfa84 Compare January 6, 2025 08:19

noaov1 approved these changes Jan 6, 2025

View reviewed changes

noaov1 merged commit 886e893 into main-v0.13.4 Jan 6, 2025
21 checks passed

noaov1 deleted the meship/update_cairo_native branch January 6, 2025 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(cairo_native): update cairo native version to 0.2.5-rc1 #2839

chore(cairo_native): update cairo native version to 0.2.5-rc1 #2839

meship-starkware commented Dec 19, 2024

reviewable-StarkWare commented Dec 19, 2024

github-actions bot commented Dec 19, 2024 •

edited

Loading

meship-starkware left a comment

meship-starkware left a comment

meship-starkware left a comment

noaov1 left a comment

meship-starkware left a comment

noaov1 left a comment

noaov1 left a comment

github-actions bot commented Dec 29, 2024

github-actions bot commented Dec 29, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Jan 1, 2025

meship-starkware left a comment

github-actions bot commented Jan 1, 2025

meship-starkware left a comment

noaov1 left a comment

dorimedini-starkware left a comment

noaov1 left a comment

dorimedini-starkware left a comment

noaov1 left a comment

noaov1 left a comment

noaov1 left a comment

chore(cairo_native): update cairo native version to 0.2.5-rc1 #2839

chore(cairo_native): update cairo native version to 0.2.5-rc1 #2839

Conversation

meship-starkware commented Dec 19, 2024

reviewable-StarkWare commented Dec 19, 2024

github-actions bot commented Dec 19, 2024 • edited Loading

meship-starkware left a comment

Choose a reason for hiding this comment

meship-starkware left a comment

Choose a reason for hiding this comment

meship-starkware left a comment

Choose a reason for hiding this comment

noaov1 left a comment

Choose a reason for hiding this comment

meship-starkware left a comment

Choose a reason for hiding this comment

noaov1 left a comment

Choose a reason for hiding this comment

noaov1 left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 29, 2024

github-actions bot commented Dec 29, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Jan 1, 2025

meship-starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 1, 2025

meship-starkware left a comment

Choose a reason for hiding this comment

noaov1 left a comment

Choose a reason for hiding this comment

dorimedini-starkware left a comment

Choose a reason for hiding this comment

noaov1 left a comment

Choose a reason for hiding this comment

dorimedini-starkware left a comment

Choose a reason for hiding this comment

noaov1 left a comment

Choose a reason for hiding this comment

noaov1 left a comment

Choose a reason for hiding this comment

noaov1 left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 19, 2024 •

edited

Loading