Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blockifier): remove warning on unneeded conversion #2726

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore(blockifier): remove warning on unneeded conversion #2726

merged 1 commit into from
Dec 17, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Dec 17, 2024 •
edited
Loading

The warning is:

warning: useless conversion to the same type: `starknet_api::execution_resources::GasAmount`
    --> crates/blockifier/src/transaction/transactions_test.rs:2419:25
     |
2419 |             sierra_gas: gas_consumed.into(),
     |                         ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `gas_consumed`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
     = note: `#[warn(clippy::useless_conversion)]` on by default

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Artifacts upload workflows:

Itay-Tsabary-Starkware
Itay-Tsabary-Starkware approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @TzahiTaub)

@ArniStarkware ArniStarkware marked this pull request as ready for review December 17, 2024 14:17
ArniStarkware
ArniStarkware commented Dec 17, 2024
View reviewed changes
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@ArniStarkware ArniStarkware merged commit 52a7d93 into main Dec 17, 2024
13 of 20 checks passed
@ArniStarkware ArniStarkware deleted the arni/warnings/blockifier_transaction_test/gas_consumed_conversion branch December 17, 2024 14:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware Itay-Tsabary-Starkware approved these changes

@TzahiTaub TzahiTaub Awaiting requested review from TzahiTaub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @reviewable-StarkWare @Itay-Tsabary-Starkware