-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blockifier): typo in infinite_gas_for_vm_mode #2704
fix(blockifier): typo in infinite_gas_for_vm_mode #2704
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2f32a5b
to
03eb7b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
03eb7b4
to
e612450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on @TzahiTaub)
crates/blockifier/src/transaction/transactions_test.rs
line 263 at r2 (raw file):
}; let initial_gas = match cairo_version { CairoVersion::Cairo0 => inifite_gas_for_vm_mode(),
infinite
Code quote:
inifite
crates/blockifier/src/transaction/transactions_test.rs
line 2692 at r2 (raw file):
actual_execution_info.validate_call_info.as_ref().unwrap().call.initial_gas; let expected_validate_initial_gas = match account_tracked_resource { TrackedResource::CairoSteps => VERSIONED_CONSTANTS.inifite_gas_for_vm_mode(),
infinite
Code quote:
.inifite
crates/blockifier/src/transaction/transactions_test.rs
line 2818 at r2 (raw file):
actual_execution_info.validate_call_info.as_ref().unwrap().call.initial_gas; let expected_validate_initial_gas = match account_tracked_resource { TrackedResource::CairoSteps => VERSIONED_CONSTANTS.inifite_gas_for_vm_mode(),
infinite
Code quote:
inifite
e612450
to
9b4c867
Compare
9b4c867
to
00bf075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 6 files reviewed, all discussions resolved (waiting on @TzahiTaub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 6 files at r1, 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
No description provided.