Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockifier): typo in infinite_gas_for_vm_mode #2704

Merged

Conversation

TzahiTaub
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

TzahiTaub commented Dec 16, 2024

@TzahiTaub TzahiTaub marked this pull request as ready for review December 16, 2024 15:49
@TzahiTaub TzahiTaub deleted the branch main December 16, 2024 16:02
@TzahiTaub TzahiTaub closed this Dec 16, 2024
@TzahiTaub TzahiTaub reopened this Dec 16, 2024
@TzahiTaub TzahiTaub changed the base branch from 11-14-feat_blockifier_update_gas_and_vm_resources_computations to main December 16, 2024 16:04
@TzahiTaub TzahiTaub force-pushed the 12-16-fix_blockifier_typo_in_infinite_gas_for_vm_mode branch from 2f32a5b to 03eb7b4 Compare December 16, 2024 16:04
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@TzahiTaub TzahiTaub force-pushed the 12-16-fix_blockifier_typo_in_infinite_gas_for_vm_mode branch from 03eb7b4 to e612450 Compare December 18, 2024 15:07
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on @TzahiTaub)


crates/blockifier/src/transaction/transactions_test.rs line 263 at r2 (raw file):

    };
    let initial_gas = match cairo_version {
        CairoVersion::Cairo0 => inifite_gas_for_vm_mode(),

infinite

Code quote:

inifite

crates/blockifier/src/transaction/transactions_test.rs line 2692 at r2 (raw file):

        actual_execution_info.validate_call_info.as_ref().unwrap().call.initial_gas;
    let expected_validate_initial_gas = match account_tracked_resource {
        TrackedResource::CairoSteps => VERSIONED_CONSTANTS.inifite_gas_for_vm_mode(),

infinite

Code quote:

.inifite

crates/blockifier/src/transaction/transactions_test.rs line 2818 at r2 (raw file):

        actual_execution_info.validate_call_info.as_ref().unwrap().call.initial_gas;
    let expected_validate_initial_gas = match account_tracked_resource {
        TrackedResource::CairoSteps => VERSIONED_CONSTANTS.inifite_gas_for_vm_mode(),

infinite

Code quote:

inifite

@aner-starkware aner-starkware force-pushed the 12-16-fix_blockifier_typo_in_infinite_gas_for_vm_mode branch from e612450 to 9b4c867 Compare December 22, 2024 15:58
@aner-starkware aner-starkware force-pushed the 12-16-fix_blockifier_typo_in_infinite_gas_for_vm_mode branch from 9b4c867 to 00bf075 Compare December 22, 2024 16:48
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 6 files reviewed, all discussions resolved (waiting on @TzahiTaub)

Copy link
Contributor Author

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 6 files at r1, 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@TzahiTaub TzahiTaub merged commit edafd7e into main Dec 23, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants