chore(cairo_native): allow disabling native compilation in the contract class manager #2703
Conversation
|
This change is |
|
Artifacts upload workflows: |
avi-starkware
force-pushed
the
avi/compilation-thread/add-config
branch
from
b6bffd0 to
49520e2
Compare
avi-starkware
changed the title
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)
crates/blockifier/src/state/contract_class_manager.rs line 103 at r1 (raw file):
pub fn set_casm(&self, class_hash: ClassHash, compiled_class: RunnableCompiledClass) { self.contract_caches.set_casm(class_hash, compiled_class); }
Why do we need the set casm function?
Code quote:
/// Sets the casm compiled class for the given class hash in the cache.
pub fn set_casm(&self, class_hash: ClassHash, compiled_class: RunnableCompiledClass) {
self.contract_caches.set_casm(class_hash, compiled_class);
}
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/blockifier/src/state/contract_class_manager.rs line 103 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Why do we need the set casm function?
When just getting the casm and not using sierra to native compilation (e.g., when using cairo 0, or when native compilation is disabled).
We need to be able to use the casm cache directly as a normal cache - setting the value obtained from the state when it couldn't be found in cache.
No description provided.