Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(consensus): remove irrelevant TODO items #2671

Merged
merged 1 commit into from
Dec 25, 2024
Merged

chore(consensus): remove irrelevant TODO items #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/papyrus_protobuf/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ license-file.workspace = true
testing = ["papyrus_test_utils", "rand", "rand_chacha"]

[dependencies]
# TODO(Guy): Remove after implementing broadcast streams.
indexmap.workspace = true
lazy_static.workspace = true
primitive-types.workspace = true
Expand Down
1 change: 0 additions & 1 deletion crates/papyrus_protobuf/src/consensus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ where
T: Clone + Into<Vec<u8>> + TryFrom<Vec<u8>, Error = ProtobufConversionError>,
{
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
// TODO(guyn): add option to display when message is Fin and doesn't have content (PR #1048)
if let StreamMessageBody::Content(message) = &self.message {
let message: Vec<u8> = message.clone().into();
write!(
Expand Down
4 changes: 0 additions & 4 deletions crates/sequencing/papyrus_consensus/src/manager_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ async fn manager_multiple_heights_unordered() {
mock_register_broadcast_topic().unwrap();
let mut sender = mock_network.broadcasted_messages_sender;

// TODO(guyn): refactor this test to pass proposals through the correct channels.
let (mut proposal_receiver_sender, mut proposal_receiver_receiver) =
mpsc::channel(CHANNEL_SIZE);

Expand Down Expand Up @@ -149,7 +148,6 @@ async fn run_consensus_sync() {
let mut context = MockTestContext::new();
let (decision_tx, decision_rx) = oneshot::channel();

// TODO(guyn): refactor this test to pass proposals through the correct channels.
let (mut proposal_receiver_sender, proposal_receiver_receiver) = mpsc::channel(CHANNEL_SIZE);

expect_validate_proposal(&mut context, Felt::TWO);
Expand Down Expand Up @@ -214,7 +212,6 @@ async fn run_consensus_sync_cancellation_safety() {
let proposal_handled = Arc::new(Notify::new());
let (decision_tx, decision_rx) = oneshot::channel();

// TODO(guyn): refactor this test to pass proposals through the correct channels.
let (mut proposal_receiver_sender, proposal_receiver_receiver) = mpsc::channel(CHANNEL_SIZE);

expect_validate_proposal(&mut context, Felt::ONE);
Expand Down Expand Up @@ -287,7 +284,6 @@ async fn test_timeouts() {
mock_register_broadcast_topic().unwrap();
let mut sender = mock_network.broadcasted_messages_sender;

// TODO(guyn): refactor this test to pass proposals through the correct channels.
let (mut proposal_receiver_sender, mut proposal_receiver_receiver) =
mpsc::channel(CHANNEL_SIZE);

Expand Down
Loading