-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native_blockifier): remove unused resource from actual_resources #2588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
crates/native_blockifier/src/py_block_executor.rs
line 106 at r1 (raw file):
.map(|(builtin, value)| (builtin.to_str_with_suffix().to_string(), *value)), ); // TODO(Yoni) remove these since we pass the gas vector in separate.
how is the gas vector currently being passed?
Code quote:
// TODO(Yoni) remove these since we pass the gas vector in separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/native_blockifier/src/py_block_executor.rs
line 106 at r1 (raw file):
Previously, dorimedini-starkware wrote…
how is the gas vector currently being passed?
As total_gas
https://github.com/starkware-industries/starkware/blob/c49046547f31b6d9f417a43dd9e8dcdec7320ac8/src/starkware/starknet/business_logic/execution/objects.py#L771
Regardless, no one access these keys in python.
2bb999d
to
61ce6c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
===========================================
+ Coverage 40.10% 60.54% +20.43%
===========================================
Files 26 153 +127
Lines 1895 19534 +17639
Branches 1895 19534 +17639
===========================================
+ Hits 760 11826 +11066
- Misses 1100 6954 +5854
- Partials 35 754 +719 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
61ce6c4
to
495b895
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
495b895
to
6c6a5d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
No description provided.