Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(native_blockifier): remove unused resource from actual_resources #2588

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 9, 2024

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)


crates/native_blockifier/src/py_block_executor.rs line 106 at r1 (raw file):

                .map(|(builtin, value)| (builtin.to_str_with_suffix().to_string(), *value)),
        );
        // TODO(Yoni) remove these since we pass the gas vector in separate.

how is the gas vector currently being passed?

Code quote:

// TODO(Yoni) remove these since we pass the gas vector in separate.

Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/native_blockifier/src/py_block_executor.rs line 106 at r1 (raw file):

Previously, dorimedini-starkware wrote…

how is the gas vector currently being passed?

As total_gas https://github.com/starkware-industries/starkware/blob/c49046547f31b6d9f417a43dd9e8dcdec7320ac8/src/starkware/starknet/business_logic/execution/objects.py#L771
Regardless, no one access these keys in python.

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/resources/rm-unused branch 2 times, most recently from 2bb999d to 61ce6c4 Compare December 10, 2024 07:28
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.54%. Comparing base (e3165c4) to head (495b895).
Report is 804 commits behind head on main.

Files with missing lines Patch % Lines
crates/native_blockifier/src/py_block_executor.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2588       +/-   ##
===========================================
+ Coverage   40.10%   60.54%   +20.43%     
===========================================
  Files          26      153      +127     
  Lines        1895    19534    +17639     
  Branches     1895    19534    +17639     
===========================================
+ Hits          760    11826    +11066     
- Misses       1100     6954     +5854     
- Partials       35      754      +719     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/resources/rm-unused branch from 61ce6c4 to 495b895 Compare December 10, 2024 11:25
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/resources/rm-unused branch from 495b895 to 6c6a5d7 Compare December 18, 2024 13:33
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@Yoni-Starkware Yoni-Starkware merged commit 7bced49 into main Dec 18, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants