Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_api): move test utils constants to starknet api #2446

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware ArniStarkware marked this pull request as ready for review December 4, 2024 10:01
@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch from 862c770 to 11f3e05 Compare December 4, 2024 10:03
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from ab38cfb to 0f24883 Compare December 4, 2024 10:03
@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch from 11f3e05 to 57d8ea0 Compare December 4, 2024 10:08
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from 0f24883 to f37d328 Compare December 4, 2024 10:08
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.52%. Comparing base (f32d098) to head (763ff23).

Additional details and impacted files
@@                                Coverage Diff                                 @@
##           arni/gas_prices/default_for_testing/unchecked    #2446       +/-   ##
==================================================================================
- Coverage                                          80.02%   51.52%   -28.50%     
==================================================================================
  Files                                                 98      291      +193     
  Lines                                              13596    33200    +19604     
  Branches                                           13596    33200    +19604     
==================================================================================
+ Hits                                               10880    17106     +6226     
- Misses                                              2232    14951    +12719     
- Partials                                             484     1143      +659     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware
Copy link
Contributor Author

crates/blockifier/src/test_utils/struct_impls.rs line 137 at r1 (raw file):

pub trait BlockInfoExt {
    fn create_for_testing() -> Self;
    fn create_for_testing_with_kzg(use_kzg_da: bool) -> Self;

Delete this.

Code quote:

pub trait BlockInfoExt {
    fn create_for_testing() -> Self;
    fn create_for_testing_with_kzg(use_kzg_da: bool) -> Self;

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 9 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @yair-starkware)


crates/blockifier/src/test_utils/struct_impls.rs line 137 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Delete this.

Here?

@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch from f32d098 to af99903 Compare December 16, 2024 15:49
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from 763ff23 to 120ccfc Compare December 16, 2024 15:50
@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch from af99903 to ff3cbab Compare December 16, 2024 18:31
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from 120ccfc to 0b9b241 Compare December 16, 2024 18:31
@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch from ff3cbab to 7df0d42 Compare December 16, 2024 18:52
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from 0b9b241 to 534fc0c Compare December 16, 2024 18:52
@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch from 7df0d42 to fabc719 Compare December 17, 2024 07:56
@ArniStarkware
Copy link
Contributor Author

crates/blockifier/src/test_utils/struct_impls.rs line 137 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Here?

Done.

@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from 534fc0c to 9896be8 Compare December 17, 2024 07:56
@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch from fabc719 to ee7467d Compare December 17, 2024 11:57
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from 9896be8 to 0e192a3 Compare December 17, 2024 11:57
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch from ee7467d to 2db8500 Compare December 18, 2024 11:24
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from 0e192a3 to efca101 Compare December 18, 2024 11:24
@ArniStarkware ArniStarkware requested a review from alonh5 December 18, 2024 11:26
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @yair-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/gas_prices/default_for_testing/unchecked branch 2 times, most recently from 423ec5d to 00179e3 Compare December 18, 2024 11:43
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from efca101 to e282678 Compare December 18, 2024 11:43
Copy link
Contributor Author

ArniStarkware commented Dec 18, 2024

Merge activity

  • Dec 18, 7:09 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 18, 7:11 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 18, 8:07 AM EST: A user merged this pull request with Graphite.

@ArniStarkware ArniStarkware changed the base branch from arni/gas_prices/default_for_testing/unchecked to graphite-base/2446 December 18, 2024 12:09
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2446 to main December 18, 2024 12:09
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_to_snapi branch from e282678 to c27d6e1 Compare December 18, 2024 12:10
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @yair-starkware)

@ArniStarkware ArniStarkware merged commit 6984361 into main Dec 18, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants