-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_api): move test utils constants to starknet api #2446
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
862c770
to
11f3e05
Compare
ab38cfb
to
0f24883
Compare
11f3e05
to
57d8ea0
Compare
0f24883
to
f37d328
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## arni/gas_prices/default_for_testing/unchecked #2446 +/- ##
==================================================================================
- Coverage 80.02% 51.52% -28.50%
==================================================================================
Files 98 291 +193
Lines 13596 33200 +19604
Branches 13596 33200 +19604
==================================================================================
+ Hits 10880 17106 +6226
- Misses 2232 14951 +12719
- Partials 484 1143 +659 ☔ View full report in Codecov by Sentry. |
Delete this. Code quote: pub trait BlockInfoExt {
fn create_for_testing() -> Self;
fn create_for_testing_with_kzg(use_kzg_da: bool) -> Self; |
57d8ea0
to
f32d098
Compare
f37d328
to
763ff23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 9 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @yair-starkware)
crates/blockifier/src/test_utils/struct_impls.rs
line 137 at r1 (raw file):
Previously, ArniStarkware (Arnon Hod) wrote…
Delete this.
Here?
f32d098
to
af99903
Compare
763ff23
to
120ccfc
Compare
af99903
to
ff3cbab
Compare
120ccfc
to
0b9b241
Compare
ff3cbab
to
7df0d42
Compare
0b9b241
to
534fc0c
Compare
7df0d42
to
fabc719
Compare
Previously, alonh5 (Alon Haramati) wrote…
Done. |
534fc0c
to
9896be8
Compare
fabc719
to
ee7467d
Compare
9896be8
to
0e192a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
ee7467d
to
2db8500
Compare
0e192a3
to
efca101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @yair-starkware)
423ec5d
to
00179e3
Compare
efca101
to
e282678
Compare
e282678
to
c27d6e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @yair-starkware)
No description provided.